Skip to content

[Tutorial,PWGCF,PWGEM,PWGHF,PWGLF,PWGMM,PWGUD] Fix includes and using statements#15392

Open
vkucera wants to merge 1 commit intoAliceO2Group:masterfrom
vkucera:fixes-Tutorials
Open

[Tutorial,PWGCF,PWGEM,PWGHF,PWGLF,PWGMM,PWGUD] Fix includes and using statements#15392
vkucera wants to merge 1 commit intoAliceO2Group:masterfrom
vkucera:fixes-Tutorials

Conversation

@vkucera
Copy link
Copy Markdown
Collaborator

@vkucera vkucera commented Mar 13, 2026

No description provided.

@alibuild alibuild mentioned this pull request Mar 13, 2026
Merged
@github-actions github-actions bot changed the title Fix includes and using statements [Tutorial,PWGCF,PWGEM,PWGHF,PWGLF,PWGMM,PWGUD] Fix includes and using statements Mar 13, 2026
vkucera pushed a commit to vkucera/O2Physics that referenced this pull request Mar 13, 2026
@alibuild
Please consider the following formatting changes to AliceO2Group#15392 (
e1bd030 
#145)
@vkucera vkucera force-pushed the fixes-Tutorials branch 4 times, most recently from 5738941 to 94873fc Compare March 26, 2026 09:43
This was referenced Mar 26, 2026
Open
Open
@vkucera vkucera marked this pull request as ready for review March 26, 2026 15:03
@ktf
Copy link
Copy Markdown
Member

ktf commented Mar 26, 2026

i think there is too much headers pulled in for the framework. we need to review this.

@vkucera
Copy link
Copy Markdown
Collaborator Author

vkucera commented Mar 26, 2026 •
edited
Loading

i think there is too much headers pulled in for the framework. we need to review this.

That means adding // IWYU pragma: export in the wrapper headers.
I'm happy to do the cleanup once we do that.

@alibuild
Copy link
Copy Markdown
Collaborator

alibuild commented Mar 26, 2026 •
edited
Loading

Error while checking build/O2Physics/o2 for f6e2a6b at 2026-03-27 07:02:

## sw/BUILD/O2Physics-latest/log
c++: fatal error: Killed signal terminated program cc1plus
c++: fatal error: Killed signal terminated program cc1plus
ninja: build stopped: subcommand failed.

Full log here.

@amatyja amatyja enabled auto-merge (squash) March 28, 2026 14:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@amatyja amatyja amatyja approved these changes

@alibuild alibuild Awaiting requested review from alibuild alibuild is a code owner

@pbuehler pbuehler Awaiting requested review from pbuehler pbuehler is a code owner

@aalkin aalkin Awaiting requested review from aalkin aalkin is a code owner

@ddobrigk ddobrigk Awaiting requested review from ddobrigk ddobrigk is a code owner

@alcaliva alcaliva Awaiting requested review from alcaliva alcaliva is a code owner

@lbariogl lbariogl Awaiting requested review from lbariogl lbariogl is a code owner

@chiarapinto chiarapinto Awaiting requested review from chiarapinto chiarapinto is a code owner

@BongHwi BongHwi Awaiting requested review from BongHwi BongHwi is a code owner

@lbarnby lbarnby Awaiting requested review from lbarnby lbarnby is a code owner

@ercolessi ercolessi Awaiting requested review from ercolessi ercolessi is a code owner

@iravasen iravasen Awaiting requested review from iravasen iravasen is a code owner

@njacazio njacazio Awaiting requested review from njacazio njacazio is a code owner

@romainschotter romainschotter Awaiting requested review from romainschotter romainschotter is a code owner

@skundu692 skundu692 Awaiting requested review from skundu692 skundu692 is a code owner

@lhusova lhusova Awaiting requested review from lhusova lhusova is a code owner

@fcolamar fcolamar Awaiting requested review from fcolamar fcolamar is a code owner

@fgrosa fgrosa Awaiting requested review from fgrosa fgrosa is a code owner

@gluparel gluparel Awaiting requested review from gluparel gluparel is a code owner

@mikesas mikesas Awaiting requested review from mikesas mikesas is a code owner

@rbailhac rbailhac Awaiting requested review from rbailhac rbailhac is a code owner

@dsekihat dsekihat Awaiting requested review from dsekihat dsekihat is a code owner

@ivorobye ivorobye Awaiting requested review from ivorobye ivorobye is a code owner

@feisenhu feisenhu Awaiting requested review from feisenhu feisenhu is a code owner

@jgrosseo jgrosseo Awaiting requested review from jgrosseo jgrosseo is a code owner

@victor-gonzalez victor-gonzalez Awaiting requested review from victor-gonzalez victor-gonzalez is a code owner

@zchochul zchochul Awaiting requested review from zchochul zchochul is a code owner

@iarsene iarsene Awaiting requested review from iarsene iarsene is a code owner

@ktf ktf Awaiting requested review from ktf ktf is a code owner

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

datamodel pwgcf pwgem pwghf PWG-HF pwglf pwgmm pwgud tutorial

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@vkucera @ktf @alibuild @amatyja